-
Couldn't load subscription status.
- Fork 3.4k
Stop early if no allowed entry types in v2 checkpoint #26940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideOptimizes getV2CheckpointTransactionLogEntries by short-circuiting when there are no ADD/REMOVE entry types, preventing unnecessary sidecar file processing. Flow diagram for early exit in getV2CheckpointTransactionLogEntriesflowchart TD
A["getV2CheckpointTransactionLogEntries called"] --> B["Compute intersection of entryTypes and {ADD, REMOVE}"]
B --> C{Is dataEntryTypes empty?}
C -- Yes --> D["Return empty Stream"]
C -- No --> E["Proceed to getV2CheckpointEntries and process sidecar files"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@chenjian2664 Could you fix CI failures? |
98caac1 to
c955581
Compare
|
updated |
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:
Summary by Sourcery
Enhancements: